From f62c6e47c5de8d3b986a6712c2a26f5809b43a17 Mon Sep 17 00:00:00 2001 From: Donato Capitella Date: Mon, 17 Nov 2025 15:30:19 +0000 Subject: [PATCH] updated benchmark script to cover HBLASLT for all rocm backends --- benchmark/run_benchmarks.sh | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/benchmark/run_benchmarks.sh b/benchmark/run_benchmarks.sh index bd8528a..3dd0011 100755 --- a/benchmark/run_benchmarks.sh +++ b/benchmark/run_benchmarks.sh @@ -39,26 +39,33 @@ declare -A CMDS=( [vulkan_radv]="toolbox run -c llama-vulkan-radv -- /usr/sbin/llama-bench" ) +get_hblt_modes() { + local env="$1" + if [[ "$env" == rocm* ]]; then + printf '%s\n' default off + else + printf '%s\n' default + fi +} + for MODEL_PATH in "${MODEL_PATHS[@]}"; do MODEL_NAME="$(basename "$MODEL_PATH" .gguf)" for ENV in "${!CMDS[@]}"; do CMD="${CMDS[$ENV]}" - - # For ROCm 6.4.4 and 7 envs, run default + HIPBLASLT=0 variants; others: default only - if [[ "$ENV" == rocm7* || "$ENV" == rocm6_4_* ]]; then - HBLT_MODES=( default off ) - else - HBLT_MODES=( default ) - fi + mapfile -t HBLT_MODES < <(get_hblt_modes "$ENV") for MODE in "${HBLT_MODES[@]}"; do BASE_SUFFIX="" CMD_EFFECTIVE="$CMD" - if [[ "$MODE" == off ]]; then - BASE_SUFFIX="__hblt0" - # inject env inside the container invocation: after the "--" - CMD_EFFECTIVE="${CMD_EFFECTIVE/-- /-- env ROCBLAS_USE_HIPBLASLT=0 }" + + if [[ "$ENV" == rocm* ]]; then + if [[ "$MODE" == off ]]; then + BASE_SUFFIX="__hblt0" + CMD_EFFECTIVE="${CMD_EFFECTIVE/-- /-- env ROCBLAS_USE_HIPBLASLT=0 }" + else + CMD_EFFECTIVE="${CMD_EFFECTIVE/-- /-- env ROCBLAS_USE_HIPBLASLT=1 }" + fi fi # run twice: baseline and with flash attention