julian/amd-strix-halo-toolboxes
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix: remove trailing backslash (#60)

Browse Source 
* feat: add REPO/BRANCH build args for llama.cpp

- Introduce ARG REPO and ARG BRANCH to replace the hardcoded git clone with: `git clone -b ${BRANCH} --single-branch --recursive ${REPO}` . This allows overriding the llama.cpp repository and branch at build time via `--build-arg`.

- Update `docs/building.md` to recommend using `--build-arg` instead of updating the file

* fix: remove trailing backslash
This commit is contained in:
Trevor Starick
2026-02-17 16:41:55 -05:00
committed by GitHub
parent be936d6b59
commit 95aaf23a47
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolboxes/Dockerfile.rocm-6.4.4
+1 -1
View File
@@ -13,7 +13,7 @@ RUN dnf -y --nodocs --setopt=install_weak_deps=False \
WORKDIR /opt/llama.cpp WORKDIR /opt/llama.cpp
ARG REPO=https://github.com/ggerganov/llama.cpp.git ARG REPO=https://github.com/ggerganov/llama.cpp.git
ARG BRANCH=master ARG BRANCH=master
RUN git clone -b ${BRANCH} --single-branch --recursive ${REPO} . \ RUN git clone -b ${BRANCH} --single-branch --recursive ${REPO} .
# build + install # build + install
RUN git clean -xdf \ RUN git clean -xdf \
toolboxes/Dockerfile.rocm-7.2
+1 -1
View File
@@ -36,7 +36,7 @@ ENV ROCM_PATH=/opt/rocm \
WORKDIR /opt/llama.cpp WORKDIR /opt/llama.cpp
ARG REPO=https://github.com/ggerganov/llama.cpp.git ARG REPO=https://github.com/ggerganov/llama.cpp.git
ARG BRANCH=master ARG BRANCH=master
RUN git clone -b ${BRANCH} --single-branch --recursive ${REPO} . \ RUN git clone -b ${BRANCH} --single-branch --recursive ${REPO} .
# build # build
RUN git clean -xdf \ RUN git clean -xdf \
toolboxes/Dockerfile.vulkan-amdvlk
+1 -1
View File
@@ -19,7 +19,7 @@ RUN curl -L -o /tmp/amdvlk-2025.Q2.1.x86_64.rpm \
WORKDIR /opt/llama.cpp WORKDIR /opt/llama.cpp
ARG REPO=https://github.com/ggerganov/llama.cpp.git ARG REPO=https://github.com/ggerganov/llama.cpp.git
ARG BRANCH=master ARG BRANCH=master
RUN git clone -b ${BRANCH} --single-branch --recursive ${REPO} . \ RUN git clone -b ${BRANCH} --single-branch --recursive ${REPO} .
# build # build
RUN git clean -xdf \ RUN git clean -xdf \
toolboxes/Dockerfile.vulkan-radv
+1 -1
View File
@@ -13,7 +13,7 @@ RUN dnf -y --nodocs --setopt=install_weak_deps=False install \
WORKDIR /opt/llama.cpp WORKDIR /opt/llama.cpp
ARG REPO=https://github.com/ggerganov/llama.cpp.git ARG REPO=https://github.com/ggerganov/llama.cpp.git
ARG BRANCH=master ARG BRANCH=master
RUN git clone -b ${BRANCH} --single-branch --recursive ${REPO} . \ RUN git clone -b ${BRANCH} --single-branch --recursive ${REPO} .
# build # build
RUN git clean -xdf \ RUN git clean -xdf \